Flame_Valxsarion wrote:V43c released. Hopefully should've fixed the last of the critical game-breaking bugs. But please let me know if you all find any more!
Was smooth sailing for quite a while, but ran into a pretty niche one. I enabled feral orcas as a monster spawn and then replaced them with Singularity in the cheat menu. Now when a group of them loses a battle it causes this exception and the battle never properly ends:
Exception: ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection.
Parameter name: index
Version :43C
System.ThrowHelper.ThrowArgumentOutOfRangeException (System.ExceptionArgument argument, System.ExceptionResource resource) (at <d7ac571ca2d04b2f981d0d886fa067cf>:0)
System.ThrowHelper.ThrowArgumentOutOfRangeException () (at <d7ac571ca2d04b2f981d0d886fa067cf>:0)
ItemStock.TransferAllItems (ItemStock destination, System.Collections.Generic.List`1[Item]& foundItems) (at <a481ff462a46453cb06e31fc2d5edf8c>:0)
TacticalMode.LootItems (System.Int32 remainingDefenders, System.String& attackerReceives, System.String& defenderReceives) (at <a481ff462a46453cb06e31fc2d5edf8c>:0)
TacticalMode.VictoryCheck () (at <a481ff462a46453cb06e31fc2d5edf8c>:0)
TacticalMode.NewTurn () (at <a481ff462a46453cb06e31fc2d5edf8c>:0)
TacticalMode.EndTurn () (at <a481ff462a46453cb06e31fc2d5edf8c>:0)
TacticalMode.ReceiveInput () (at <a481ff462a46453cb06e31fc2d5edf8c>:0)
GameManager.Update () (at <a481ff462a46453cb06e31fc2d5edf8c>:0)
For some extra details: I also tried out numerous cheat traits on Singularities (Extraction, InfiniteReincarnation, and Infinite Assimilation) and noticed that getting rid of one in the race editor wouldn't remove it from already spawned monster pack Singularities. However, even manually removing them didn't seem to affect the exception, and it still happened with later spawns that didn't have the earlier removed traits. Also I only get the exception when the Singularity pack loses. Individuals can be digested just fine, and nothing happens if they win. And for what it's worth, if there's an AI fight and I choose "skip battle show stats" I get the exception and then all the units in the after battle battle screen look really bugged. One time I also went to reload a save, accidently hit the autosave battle file, went to watch the battle instead of skipping this time, and a bunch of units on the non-singularity side started out as corpses, while all the singularities started out at negative HP, then after they finished their turn the battle just stopped.
I'll probably try using another monster to replace with singularities just to test if its the singularities or the orcas, and I'll put in an edit if anything changes.
Edit: taking out feral orca monster spawns, and putting in Goodra then replacing them with Singularities stopped the bug. The goodra singularities haven't exhibited any issues.
Edit 2: Just had the exception come up again after a solo Abakhanskya ate a full group of Singularities.
On the topic of less game breaking bugs: I think mana shield is bugged. It seems to get more effective rather than less effective as the units mana gets close to 50%. Had a fight where a Bella with only a little over 50% mana became essentially immune to damage, with hits showing up as misses (or no effect in the case of power bolt) while the text log would show them doing damage. Then when said Bella cast too many spells and went below 50% mana the mana shield effect properly disappeared. Also just a balance idea, but I think mana shield might feel more balanced if it just reduced mana by the damage prevented to hp, instead of the damage taken to HP (so if a hit would have done 7 and gets reduced to 3 then the unit with mana shield takes 3 hp damage and 4 mana damage). As is, a unit with mana shield becomes borderline unkillable to anything without a monsterously high voracity stat that can't just eat it at near full hp and bypass the mana shield. This might be different if mana shield did properly get weaker the closer to 50% mana the unit is, though, it's just that that version is a little more difficult to conceptualize without seeing it or doing a bunch of math.
Oh, and a very minor bug, but if Singularity eats someone while the sprite is facing completely forward it makes the upper belly appear in the spot it would be if she was still facing sideways, so she ends up with a floating belly.
