Masxohn wrote:Since stranger dialogue was move to here along with the innkeeper dialogue. Some suggestions and some bug reports (cause lovely bugs).
Bug reports: I noticed some things weren't working: 1: dialogue topic somewhere that should let you out of being in endo didn't, and another where their lines after letting them out remained the same as if you had just endo'd them, due to shear number I wasn't able to track them down. 2: as I was in SSEEdit I went to take a look at stranger dialogue (it really did need better organization and proper labeling) and noticed a few of them had < Error: Could not be resolved > decided to do the quick check in SSEEdit for errors and got 138 out of 1793 records which seems to all the stranger dialogue (no clue what ##0F3DDF or ##0F3DE0 are supposed to even be along with the other 3 or 6 other error formids).
Suggestion: I'd separate out stranger + innkeeper dialogue into a separate (both of them in it) esp (possible esl?) largely due to dialogue context/difference resulting in it sticking out like a sore thumb amongst the other dialogues, and also for better ease in finding and fixing bugs.
Ironically just before it was removed from Refactor I'd figured out what was wrong exactly (with it's way of doing it then) and fixed it and reported how to fix it.
Ah yikes, I got the dialoguemeister on my case. Seriously though Max your bug reports are always super well-informed, thanks for stopping in.
Are you using the very latest version (from 8pm central today)? Looking at that one with xEdit, I only see one error, in a place that shouldn't affect anything.
Concerning the organization, yeah, it's a bit labyrinthine. I doubt Ryan ever expected anyone else to look into the tree structure, so it's very compact... And more or less indecipherable. I actually compacted it more today to solve a number of problems caused by migrating it to my mod.
Mark has suggested the same idea with moving it to it's own separate esl, and it's something I'm considering. I'll have to give the implementation of that some more thought, but I probably will end up doing it eventually.